feat(waf): add new check waf_global_webacl_with_rules
#5469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5469 +/- ##
==========================================
+ Coverage 89.60% 89.63% +0.02%
==========================================
Files 1073 1074 +1
Lines 33237 33255 +18
==========================================
+ Hits 29782 29808 +26
+ Misses 3455 3447 -8 ☔ View full report in Codecov by Sentry. |
…eb-ac-ls-have-at-least-one-rule-or-rule-group
sergargar
previously approved these changes
Oct 22, 2024
sergargar
approved these changes
Oct 22, 2024
sergargar
deleted the
PRWLR-4461-ensure-aws-waf-classic-global-web-ac-ls-have-at-least-one-rule-or-rule-group
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AWS WAF Classic global web ACLs(Web Access Control Lists) are essential for controlling access to web applications. A web ACL can include a set ofrulesorrule groupsthat filter and manageHTTPandHTTPSrequests. These rules help define which traffic should be allowed, blocked, or counted, improving security and controlling access to your AWS resources such asCloudFront distributions.Description
This check verifies whether an
AWS WAF Classic global web ACLcontains at least oneruleorrule group. If no rules or rule groups are present, the web traffic might pass without inspection, leaving the application vulnerable to attacks.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.